Closed ciaradunks closed 3 years ago
@smartie2076 after making the suggested changes and running the tests, KeyError: 'maximumAddCap' is returned from D1.transformer_constant_efficiency_optimize(), for instance. Do you have an idea of why this is happening?
Yes, I do! It is the same thing that was the case in the other PR: The input files for the D0
and D1
tests are json files: tests/test_data/inputs_for_D0/mvs_config.json
and tests/test_data/inputs_for_D1/mvs_config.json
. You need to add the new parameter there as well... :/
Fix #Issue
Changes proposed in this pull request:
MaximumAddCap
(whereMaximumAddCap=MaximumCap-InstalledCap
) inC0.process_maximum_cap_constraint
MaximumCap<=InstalledCap
inC0.process_maximum_cap_constraint
MaximumCap
definition in RTD and include definition forMaximumAddCap
MaximumCap
inD1
withMaximumAddCap
calculated inC0
The following steps were realized, as well (if applies):
black . --exclude docs/
)EXECUTE_TESTS_ON=master pytest
)For more information on how to contribute check the CONTRIBUTING.md.