search

rl-institut / multi-vector-simulator

Multi-vector Simulation Tool assessing and optimizing Local Energy Systems (LES) for the E-LAND project
GNU General Public License v2.0
21 stars 10 forks source link

[Bug] ZeroDivisionError if no lifetime is provided in fixcosts.csv #851

Open Piranias opened 3 years ago

Piranias commented 3 years ago

If no fixcosts are used, there appears an error message (zero devision error) because the lifetime in fixcosts.csv is zero. This way the user has to change the lifetime to some value, even though the fixcosts are not defined afterall. Maybe at least a warning should be returned.

Error message: Fehlermeldung

and the input file were the error appears: fixcosts

Checklist to make sure that the bug report ist complete:

smartie2076 commented 3 years ago

Hi @Piranias! If you do not want to use fixcosts, you can simply delete all the columns, then you also don´t have to define anything.

The lifetime of any asset indeed always has to be > 0, but I checked and saw that this is not explained in the RTD, so that has to be fixed.

In general, input validation currently is not implemented, so there is no way for us to add default values.

Piranias commented 3 years ago

ok sure. I just stumbled across this and thought others might have the same question. If it's mentioned in the rtd that should be fine