Closed smartie2076 closed 3 years ago
There is a double structure to determine the dispatch of assets - via E1.get_timeseries_per_bus
with E1.get_flow()
assertions, and thus E1.cut_below_micro
is applied twice for each flow. This should rather be merged into the other functions.
@ciaradunks the PR is ready for review now! :)
@smartie2076 I've had a look through each commit and it all looks fine to me!
Oh, nice, no changes required =D
Fix #847
Changes proposed in this pull request: Planned changes:
AE-grid-battery
benchmark test to read from json filesAE-grid-battery
benchmark test for one case where storage can not be used and one where it can be used, so that this is made explicitAE-grid-battery
so that the issue described in #847 leads to a failing pytestSTORAGE_CAPACITY
/FLOW
orTOTAL_FLOW
is used inE
, if not, add exception thatTOTAL_FLOW
etc. forSTORAGE_CAPACITY
isNaN
. Make sure thatSOC
can still be calculated.Extra changes:
storage_filename
is validThe following steps were realized, as well (if applies):
black . --exclude docs/
)EXECUTE_TESTS_ON=master pytest
)