Fix minor issues in autoreport

rl-institut / multi-vector-simulator

Multi-vector Simulation Tool assessing and optimizing Local Energy Systems (LES) for the E-LAND project

GNU General Public License v2.0

21 stars 10 forks source link

Fix minor issues in autoreport #875

Closed smartie2076 closed 3 years ago

smartie2076 commented 3 years ago

Fix #762

Changes proposed in this pull request:

Fix E2.convert_components_to_dataframe(): Display correctly when assets (esp. storage) is optimized

The following steps were realized, as well (if applies):

[x] Use in-line comments to explain your code
[x] Write docstrings to your code (example docstring) :x: For new functionalities: Explain in readthedocs
[x] Write test(s) for your new patch of code (pytests, assertion debug messages)
[x] Update the CHANGELOG.md
[x] Apply black (black . --exclude docs/)
[ ] Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

smartie2076 commented 3 years ago

Another identified issue: grafik Used here https://github.com/rl-institut/multi-vector-simulator/blob/dev/src/multi_vector_simulator/F2_autoreport.py#L783 And with default definitions here: https://github.com/rl-institut/multi-vector-simulator/blob/dev/src/multi_vector_simulator/utils/constants.py#L264 The scenario_definition parameter is defined, but still there is an error message:

16:49:38-ERROR-Parameter scenario_description of asset project_data (group: project_data) is missing. The simulation may continue, but errors during execution or in the results
can be expected.

Bachibouzouk commented 3 years ago

Is there a specific input data folder which one should use for testing the PR works? @smartie2076 ?

smartie2076 commented 3 years ago

Is there a specific input data folder which one should use for testing the PR works? @smartie2076 ?

The tests/inputs folder works for this, actually. The PR is not done, though!

smartie2076 commented 3 years ago

Another identified issue: Used here https://github.com/rl-institut/multi-vector-simulator/blob/dev/src/multi_vector_simulator/F2_autoreport.py#L783 And with default definitions here: https://github.com/rl-institut/multi-vector-simulator/blob/dev/src/multi_vector_simulator/utils/constants.py#L264 The scenario_definition parameter is defined, but still there is an error message:
16:49:38-ERROR-Parameter scenario_description of asset project_data (group: project_data) is missing. The simulation may continue, but errors during execution or in the results
can be expected.

This was a bug with the input files of tests/inputs, not a code-bug.

smartie2076 commented 3 years ago

Previously, the diesel generator and storage assets where faulty. Now I fixed this: grafik