search

rl-institut / multi-vector-simulator

Multi-vector Simulation Tool assessing and optimizing Local Energy Systems (LES) for the E-LAND project
GNU General Public License v2.0
21 stars 10 forks source link

Proofread output kpi in RTD #878

Closed Bachibouzouk closed 3 years ago

Bachibouzouk commented 3 years ago

Addresses part of #877

Changes proposed in this pull request:

The following steps were realized, as well (if applies):

For more information on how to contribute check the CONTRIBUTING.md.

Bachibouzouk commented 3 years ago

@smartie2076 - I would rename Connected indicators Related indicators and use | to separate them rather than , as the comma is difficult to spot, what do you think?

smartie2076 commented 3 years ago

@smartie2076 - I would rename Connected indicators Related indicators and use | to separate them rather than , as the comma is difficult to spot, what do you think?

Hm, isnt | dangerous as it might have parsing issues? How about &?

Bachibouzouk commented 3 years ago

@smartie2076 - For all the costs calculated for the whole project they are in currency from today? Is there any compensation mechanism? I think it is good to explicitly mention whether it is the case or not.

smartie2076 commented 3 years ago

@smartie2076 - For all the costs calculated for the whole project they are in currency from today? Is there any compensation mechanism? I think it is good to explicitly mention whether it is the case or not.

There is the discount factor, which can include the inflation if the user chooses to. But the costs are all present values, yes.

Bachibouzouk commented 3 years ago

Hm, isnt | dangerous as it might have parsing issues? How about &?

It is used for the RTD own documentation, I also used it for the index.rst, I find it more elegant and less cluttered than the Ampersand symbol

smartie2076 commented 3 years ago

Hm, isnt | dangerous as it might have parsing issues? How about &?

It is used for the RTD own documentation, I also used it for the index.rst, I find it more elegant and less cluttered than the Ampersand symbol

Allright, then I am fine with it

Bachibouzouk commented 3 years ago

In the definition of the costs, examples would be very welcome (e.g. "Costs for fix annual operation" could be "Costs for fix annual operation (e.g XYZ land use tax)")

Bachibouzouk commented 3 years ago

The variable named costs_cost_om could be renamed costs_om_specific ?

Bachibouzouk commented 3 years ago

In the definition of the costs, examples would be very welcome (e.g. "Costs for fix annual operation" could be "Costs for fix annual operation (e.g XYZ land use tax)")

For this one I would let you add the example as I am still novice in this area, I'll tag you when I won't modify the PR anymore

Bachibouzouk commented 3 years ago

The unit currency/a means currency per annum?

smartie2076 commented 3 years ago

The variable named costs_cost_om could be renamed costs_om_specific ?

Hmm but they are not specific anymore. Initially, they should be costs_om, but I think the titles for the costs are auto-generated, that is why there is the duplication of cost/costs. Also belongs into the category of properly renaming the economic output parameters (for the report and files)

Bachibouzouk commented 3 years ago

The units enumeration KW/KWh/KWp is misleading, it should read KW, KWh/h, KWp instead. Many places to change this in MVS_kpis_list.csv.

Bachibouzouk commented 3 years ago

@smartie2076 - What is the physical meaning of the definition of Energy excess? Excess of electricity / unused electricity in local energy system.

  1. Is it energy or electricity excess?
  2. Where does it physically go? Electricity excess which cannot go in a storage or be consumed right away must be dissipated somehow and quickly.

Is it there to track how much energy was generated and could not be dispatched in the LES or as feedin? If it is non-zero was are the implications for a real case? That they would be costs associated to having to sell this as feedin eventhough the price is not good? Or one should build storage to absorb it if the feedin capacity cannot take the flow?

Bachibouzouk commented 3 years ago

The example of the Renewable share of local generation could be a bit more general with not only 100% Electricity and 0% Heat and also using the weights aforementioned (one source of non renewable so that the global RE share is not trivially 100%

Bachibouzouk commented 3 years ago

The DSC does not have its definition, type, unit, range attributes as other KPIs.

Bachibouzouk commented 3 years ago

Shouldn't the definition of DA be based on energy provider rather than DSO, limiting it to electricity only?

Bachibouzouk commented 3 years ago

The description of equation parameters should all ressemble the one of the renewable factor, some of the equation below do not define their variables in the same fashion

Bachibouzouk commented 3 years ago

A nicer image of input PV timeseries could be selected (with over a year for example), this graph is not very impressive

Bachibouzouk commented 3 years ago

The screen shot of the report is not readable, should we link it as pdf file to download instead? (then add it to the appendix of the report for example)

Bachibouzouk commented 3 years ago

I listed all the things that came up to my attention as I did not have the time to fix them on the spot. I wanted to info to be out, so then someone else could also address those points

smartie2076 commented 3 years ago

@Bachibouzouk okay, thank you for the remarks! I guess I take over now. First, a checklist of your made points:

Comments:

The DSC does not have its definition, type, unit, range attributes as other KPIs.

Yes, and actually I would comment the DSC out for the upcoming release. This KPI is not being calculated right now, but something I definitly want to follow up with later.

@smartie2076 - What is the physical meaning of the definition of Energy excess? Excess of electricity / unused electricity in local energy system. Is it energy or electricity excess?

It is energy excess of any energy carrier, and it is energy that can not be used in the energy system and therefore has to be "vented" (no export possible or not preferrable)

Where does it physically go? Electricity excess which cannot go in a storage or be consumed right away must be dissipated somehow and quickly.

This was a discussion sometime at the beginning. In our model, all excess energy is simply fed into an excess sink and this then "vents"/"dissipates" it. Of course, that is not how it would work in reality, but that is what we are going to use. Should that be explained better in https://multi-vector-simulator.readthedocs.io/en/latest/model/components.html#energy-excess?

Is it there to track how much energy was generated and could not be dispatched in the LES or as feedin? If it is non-zero was are the implications for a real case? That they would be costs associated to having to sell this as feedin eventhough the price is not good? Or one should build storage to absorb it if the feedin capacity cannot take the flow?

We do track the excess generation per vector, yes. There are no consequences of that. If excess generation is excessively large, an error message is displayed.

smartie2076 commented 3 years ago

Hi @Bachibouzouk I now referenced the need to improve KPI descriptions in #883, but would like to merge this until tomorrow afternoon. I already rebased, and would merge after your okay. I adressed all other points (see checklist)