Correct weighting factors

[TheOneAndra]

Fix #822

Changes proposed in this pull request:

• Correct the weighting factors

The following steps were realized, as well (if applies):

• [x] Use in-line comments to explain your code
• [x] Write docstrings to your code (example docstring)
• [x] For new functionalities: Explain in readthedocs
• [x] Write test(s) for your new patch of code (pytests, assertion debug messages)
• [x] Update the CHANGELOG.md
• [x] Apply black (black . --exclude docs/)
• [x] Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

Please mark above checkboxes as following:

• [ ] Open
• [x] Done

:x: Check not applicable to this PR

_{For more information on how to contribute check the CONTRIBUTING.md.}

[TheOneAndra]

I am not sure how to tackle issue #822 with the natural gas energy carrier. Should we change the table so that the user uses gas as energy vector for natural gas or should we change the energy carrier name in the MVS so that _naturalgas is accepted ?

any suggestion @smartie2076 ?

[smartie2076]

@TheOneAndra I had to update as there was a dev fix

[smartie2076]

Hi @TheOneAndra! Hm, this is also a question of an API change - when we change from Gas to Natural_gas some previously created simulations may not work anymore (also, the EPA uses Gas now). So eventhough Natural_gas is more explicit, I would not change the name in constants.py. How about you change the tables in https://multi-vector-simulator.readthedocs.io/en/latest/model/assumptions.html#weighting-of-energy-carriers and make Gas oil/diesel --> Diesel and Natural gas --> Gas? Maybe you can also add a warning like this at the end of the section?

.. note::
   The :code:`energy_vector` of each of the assets and busses must be identical in spelling to one of the energy carriers defined in the above table. Other energy carriers can not be parsed and will raise a warning. Please note that `Heat` currently has to be measured in kWh(thermal).

[smartie2076]

Hi @TheOneAndra! Hm, this is also a question of an API change - when we change from Gas to Natural_gas some previously created simulations may not work anymore (also, the EPA uses Gas now). So eventhough Natural_gas is more explicit, I would not change the name in constants.py. How about you change the tables in https://multi-vector-simulator.readthedocs.io/en/latest/model/assumptions.html#weighting-of-energy-carriers and make Gas oil/diesel --> Diesel and Natural gas --> Gas?

Added Natural_gas, identical to Gas, as EPA needs to use Gas. It does not matter which one is used.

Maybe you can also add a warning like this at the end of the section?

Added comment