Closed Bachibouzouk closed 1 year ago
@ciaradunks, @smartie2076 what do you think?
I tested it and could cap the feedin successfully. Now I will modify RTD, add a test and maybe there are post-processing calculations which need to change? Like the power in/out of the feedin_cap bus is not interesting to look at as the information is already there from flow from normal electricity bus to transformer station.
I am not 100% sure why you need this instead of the capping through an additional transformer station between the local energy bus and the energy provider bus. From the idea, yes, this should work.
If you also introduced a consumption capping, you would symetrical features for consumption and feed-in. In the long run, this could also help to implement the issue #940, I think.
Now I will modify RTD, add a test and maybe there are post-processing calculations which need to change? Like the power in/out of the feedin_cap bus is not interesting to look at as the information is already there from flow from normal electricity bus to transformer station.
This is something I also dont know from the top of my head anymore, so I am just having a good guess here. I think it there are no costs connected with the feedin CAP, you might not have to change stuff? Maybe you should write something for future devs that if the feedin cap must be optimized, and in that scope the asset gets costs, then the economic equations should be checked again. Regarding the technical parameters: It should not change how flows of the energy provider are accessed...
I am not 100% sure why you need this instead of the capping through an additional transformer station between the local energy bus and the energy provider bus. From the idea, yes, this should work.
Isn't it what I implemented? Adding a transformer to cap the feedin. The reason I implemented this is because in open_plan the user should not need to know that one can cap by adding an "oemof transformer", we removed the ability to use oemof transformers directly in the GUI because the users had confused them with electrical transformers. The user only wants to set a capping at the DSO level and does not care what happens under the hood of MVS, this is why I implemented this.
Prior to merge this PR #939 should be merged
Fix #941
Changes proposed in this pull request:
The following steps were realized, as well (if applies):
black . --exclude docs/
)EXECUTE_TESTS_ON=master pytest
)For more information on how to contribute check the CONTRIBUTING.md.