search

rl-institut / multi-vector-simulator

Multi-vector Simulation Tool assessing and optimizing Local Energy Systems (LES) for the E-LAND project
GNU General Public License v2.0
21 stars 10 forks source link

Misleading magnitude format in test csvs #947

Open pebasantaf opened 2 years ago

pebasantaf commented 2 years ago

Often the unit for an energy price or cost has a magnitude format such as 'currency/kWh' or 'currency/kW' in the csvs. This works if we use kWh or kW correspondingly as units. But it is misleading in case we use, for example, kgH2 as unit. People might have a a tendency to pass those kgH2 to kWh as, for example, in the energy_price of EnergyProviders is indicated to input this value with a 'currency/kWh' format, but the optimizer is actually working with kgH2, if one has set it as unit. Therefore, the magnitude format for this energy_price (and other variables) should be 'currency/unit'.

Bachibouzouk commented 1 year ago

As far as I know, the unit in the csv file is up to the user to define, I should have time to test that soon as we need to make sure the use of unit is consistent for another project where we use MVS (This is essentially a GUI of MVS: https://github.com/open-plan-tool).

There is a dict with energy conversion factors : https://github.com/rl-institut/multi-vector-simulator/blob/df995df35f34f6cc4221d052d5962e0a48d97b7e/src/multi_vector_simulator/utils/constants.py#L279

I will also empower the user to change those factors more easily in the future :)