rl-institut / multi-vector-simulator

Multi-vector Simulation Tool assessing and optimizing Local Energy Systems (LES) for the E-LAND project
GNU General Public License v2.0
21 stars 10 forks source link

[Bug] Bug_short_description #951

Open Bachibouzouk opened 2 years ago

Bachibouzouk commented 2 years ago

Comparing the results of oemof solph and MVS of an energy system containing dispatchable and non-dispatchable sources the following issue came to light: When investment mode/optimization is turned off for all sources, both models give the exact same results (as desired).

When investment mode is turned on for dispatchable sources, but turned off for non-dispatchable sources, both models give the same results (as desired).

However, when investment mode is turned on for non-dispatchable sources, the investments made in these technologies differ between the two models.

This is only the case, when the variable costs (in solph) and the dispatch_price (in MVS) are not set to zero. When they are set to zero, the results match.

We found, that the reason for the mismatch lies in the definition of the variable costs in MVS. They are assigned as follows (in module D1, source_non_dispatchable_optimize): variable_costs=dict_asset[DISPATCH_PRICE][VALUE]/dict_asset[TIMESERIES_PEAK][VALUE]

Removing the division and just assigning variable_costs=dict_asset[DISPATCH_PRICE][VALUE] leads to matching results between solph and MVS

Input units were:

Looking at those units, dividing the dispatch price by the timeseries peak would lead to (currency*kWp)/kWh^2. This doesn’t seem sensible.

It seems like one of these three points has to be true:

Checklist to make sure that the bug report ist complete:

Bachibouzouk commented 2 years ago

solph and MVS investment.zip Here attached the MVS and solph models