Examples' naming out of date

rl-institut / oemof-B3

An open-source energy system model for Brandenburg/Berlin.

https://oemof-b3.readthedocs.io/

GNU Affero General Public License v3.0

9 stars 5 forks source link

Examples' naming out of date #109

Open jnnr opened 2 years ago

jnnr commented 2 years ago

Some of the values in the examples are not consistent with the rest. This leads to errors when plotting (e.g. snakemake -j1 resutls/base/plotted) Should rename to keep it work.

BE -> B
liion-battery -> liion_battery

jnnr commented 2 years ago

The problem is rather that the script in #93, which defines the regions as constants instead of using the regions of the data.

The problem with liion-battery could not be reproduced.

jnnr commented 2 years ago

There is a problem with the names of the regions when building the report (the expected regions are hard-coded).

TODO:

[x] Adapt the name of the region BE to B in the examples.
[x] Adapt the name of the plots BE to B in the reports (report.md and report_interactive.md)

monika-o commented 2 years ago

running the report: snakemake -j1 results/base/report/

monika-o commented 2 years ago

@jnnr The above command results in the error [Errno 2] No such file or directory: 'scenarios/base.yml'. Could it be that the file name in the Snakefile at line 143 is not correct? I am working on the branch fix/BE-to-B which I just created from the dev-branch, so it should be identical to the dev-branch.

jnnr commented 2 years ago

@jnnr The above command results in the error [Errno 2] No such file or directory: 'scenarios/base.yml'. Could it be that the file name in the Snakefile at line 143 is not correct? I am working on the branch fix/BE-to-B which I just created from the dev-branch, so it should be identical to the dev-branch.

Could be connected to #144

jnnr commented 2 years ago

Removed this from the release milestone as it is not ready. Dropped the target rule report_all_examples from Snakefile in 2bba3a1 for now, as the plots do not appear in the report.