search

rl-institut / oemof-B3

An open-source energy system model for Brandenburg/Berlin.
https://oemof-b3.readthedocs.io/
GNU Affero General Public License v3.0
9 stars 5 forks source link

Feature/dispatch plot region aggregated #242

Closed MaGering closed 1 year ago

MaGering commented 2 years ago

With this PR dispatch plots aggregated by regions are produced.

This PR replaces the PR in oemof-B3-methane (https://github.com/rl-institut/oemof-B3-methane/pull/28).

MaGering commented 2 years ago

Thank you for the review @jnnr. I applied our further suggestions in commits https://github.com/rl-institut/oemof-B3/pull/242/commits/a96dd2ce8b9ac7f4d9a0a4cd709cc8c4282d297f and https://github.com/rl-institut/oemof-B3/pull/242/commits/0170d7775307fe01581ab0b09e5340f631d57daa.

Would you like to review them?

MaGering commented 2 years ago

Thanks for the clarification!

I reverted the unsuitable changes with commits https://github.com/rl-institut/oemof-B3/pull/242/commits/a106ffb5dd7b3dde4f6dcf251554bb2e030cfe8c and https://github.com/rl-institut/oemof-B3/pull/242/commits/7cc8ce443d6d361467d01ec645c7ac6c7cb474b6 and implemented your approaches with commits https://github.com/rl-institut/oemof-B3/pull/242/commits/45345d473dc4c6dfe8b74229ef3396793d7f528f and https://github.com/rl-institut/oemof-B3/pull/242/commits/b291aa88893478bd9a1aa34eea6c14afedcc75bc.

MaGering commented 1 year ago

Can I merge into dev?

jnnr commented 1 year ago

Can I merge into dev?

If it works, sure!