search

rl-institut / oemof-B3

An open-source energy system model for Brandenburg/Berlin.
https://oemof-b3.readthedocs.io/
GNU Affero General Public License v3.0
9 stars 5 forks source link

Fix by adapting output path handling #341

Closed MaGering closed 1 year ago

MaGering commented 1 year ago

Resolves #303

The file type is added twice to the file name and hence the output can never be build by snakemake. With this commit the file path is set according to the file type in the settings.

This PR fixes the issue. Is only working with changes in PR https://github.com/rl-institut/oemof-B3/pull/336.

MaGering commented 1 year ago

Outdated: Again checks not working due to problem described in my comment here. Hence this PR should be merged after https://github.com/rl-institut/oemof-B3/pull/336.

Checks pass as of the state of commit https://github.com/rl-institut/oemof-B3/pull/341/commits/5e400b2f062f049173665c980274dde1e3e2fecd.

MaGering commented 1 year ago

Ready for your review @Stefanie08!

You need the changes in PR https://github.com/rl-institut/oemof-B3/pull/336 for your review. To be checked with 

snakemake -j1 plot_all_resources

or

snakemake -j1 results/_resources/plots/scal_conv_pp-capacity_net_el.png

Thanks!

MaGering commented 1 year ago

Both commands work as expected. Just as a side note: There is also a typing error in the legend

grafik

Thanks @Stefanie08. And for creating issue https://github.com/rl-institut/oemof-B3/issues/348.