search

rl-institut / oemoflex

A flexible model structure for creating and analysing multi-regional sector-integrated energy systems with oemof featuring many flexibility options.
https://oemoflex.readthedocs.io
GNU Affero General Public License v3.0
4 stars 1 forks source link

Obsolete installation of oemof with oemof.tabular? #41

Closed MaGering closed 3 years ago

MaGering commented 3 years ago

oemof is installed with the installation of oemof.tabular in install_requires of oemoflex' setup.py. As far as I'm concerned oemof is obsolete and might lead to errors when using it. Should we consider dropping oemof from the install_requires?

Originally posted by @MaGering in https://github.com/rl-institut/oemoflex/issues/26#issuecomment-930285498

jnnr commented 3 years ago

You are right that oemof is installed as a dependency of oemof.tabular. But I do not see oemof in install_requires of oemoflex.

MaGering commented 3 years ago

You are right that oemof is installed as a dependency of oemof.tabular. But I do not see oemof in install_requires of oemoflex.

It isn't. oemof is in install_requires of oemof.tabular.

MaGering commented 3 years ago

There is apparently a branch and PR in oemof.tabular which fixes this problem.

Setting 

"oemof.tabular @ git+https://git@github.com/oemof/oemof-tabular@dev#egg=oemof.tabular"

to

"oemof.tabular @ git+https://git@github.com/oemof/oemof-tabular@fix/imports_and_requirements_for_oemof_solph_040#egg=oemof.tabular"

in oemoflex's setup.py fixes this issue for now (just as long as the branch is not merged to dev in oemof.tabular)

jnnr commented 3 years ago

There is apparently a branch and PR in oemof.tabular which fixes this problem.

This branch has been almost ready for quite a while. I would not like to use that branch as a dependency as long as the authors have not concluded their work. You can try to give it a push by asking about the status there.

jnnr commented 3 years ago

@MaGering, can we close this issue?

MaGering commented 3 years ago

Isn't this only fixed with merge of https://github.com/oemof/oemof-tabular/pull/21?

jnnr commented 3 years ago

Isn't this only fixed with merge of oemof/oemof-tabular#21?

It is indeed an issue that oemof.tabular's release is delayed. However, this is an issue of oemof.tabular. There may arise issues for oemoflex because of that. But the problem of obsolete dependencies is mentioned here belongs to oemof.tabular.