rl-institut / open_plan

Bottom-up energy transition: Optimized open-source planning of electricity and heat supply in energy cells

GNU General Public License v2.0

9 stars 4 forks source link

The output parameter installed power capacity must be redefined #101

Closed FredericHirschmueller closed 3 years ago

FredericHirschmueller commented 3 years ago

We have to make two different outputs with two different units: installed power [kW] installed capacity [kWh]

TheOneAndra commented 3 years ago

PR #100 has been updated accordingly, thank you for the comment

Bachibouzouk commented 3 years ago

100 is not merged yet, therefore the issue is not closed ;)

The way to go is to write fix #101 in the description of #100, so when it gets merged, it closes this issue automatically :D

TheOneAndra commented 3 years ago

The way to go is to write fix #101 in the description of #100, so when it gets merged, it closes this issue automatically :D

Actually this is not necessary since the PR has been linked from here already: grafik

Nevertheless, does that make it easier to read when someone in a distance future searches for this? Because technically, this issue has been adressed so it could be closed

Bachibouzouk commented 3 years ago

Technically the issue has been addressed when the branch is merged in dev, this is not the case yet. (things could go banana and #100 end up deleted and not merged, then we did not solve the issue but think we did because we closed it already)

I did not know the button to link the issue, I think I still prefer explicitly writing Fix #issuenumber as per the "explicit over implicit" principle.