rl-institut / spice_ev

Simulation Program for Individual Charging Events of Electric Vehicles
MIT License
21 stars 9 forks source link

Update definition of power entering and leaving the battery, update use of efficiency #203

Open jakobgemassmer opened 8 months ago

jakobgemassmer commented 8 months ago

Implement a new definition of how to deal with efficiency:

The (dis)charging curve therefore defines P_in and P_out in this picture: image More info: https://smooth.readthedocs.io/en/latest/smooth.components.html#module-smooth.components.component_battery

Additionally: Ensure that the efficiency is considered in all strategies and for vehicles and stationary batteries! Example: In peak_load_window the stat. battery does not consider the efficiency when discharging.

stefansc1 commented 7 months ago

This is already the behavior when using target_power of the battery load/unload functions. See test_components for example, test_charging and test_unload in particular. Do you have an example file where the efficiency is not accounted for, in your opinion?