search

rlaager / docsis

This program encodes a DOCSIS binary configuration file from a human-readable text configuration file.
http://docsis.sourceforge.net
GNU General Public License v2.0
114 stars 70 forks source link

Added TLV 23.13 for DS packet classification CMIM #34

Closed tenpin784 closed 8 years ago

tenpin784 commented 8 years ago

CMIM was in place for TLV 22.13, but not for 23.13

Added CMIM for 23.13, which is needed for Alcatel Lucent DPOE solutions.

AdrianSimionov commented 8 years ago

Do you know in which specification is 23.13 described?

The reason why 22.13 was added and 23.13 was not added is that in MULPI chapter C.2.1.4.8 there is no mention about 23.13. It might be that is described somewhere else, but I would be interested to know where.

If I will find it by myself, I will update this pull request but I would really appreciate it if you can ask Alcatel Lucent engineers where is this TLV documented.

As I am travelling please expect delays in my replies.

tenpin784 commented 8 years ago

I had a helluva time finding it as well. I saw 22.13 in that same document, but not 23.13

I can try and bounce it off of them, but honestly, that might be to deep for them.

On 01/19/2016 10:49 AM, Adrian Simionov wrote:

Do you know in which specification is 23.13 described?

The reason why 22.13 was added and 23.13 was not added is that in MULPI chapter C.2.1.4.8 there is no mention about 23.13. It might be that is described somewhere else, but I would be interested to know where.

If I will find it by myself, I will update this pull request but I would really appreciate it if you can ask Alcatel Lucent engineers where is this TLV documented.

As I am travelling please expect delays in my replies.

— Reply to this email directly or view it on GitHub https://github.com/rlaager/docsis/pull/34#issuecomment-172914503.

AdrianSimionov commented 8 years ago

What I am afraid of is that it does not exist and it makes no difference in the configuration as non-recognized TLVs should be discarded by devices. A debug/log of the device might mention something about it. Or due to no documentation from Cable Labs was misunderstood by the vendor and implemented in the wrong way!

From your experience, is this TLV mandatory to make the device work? Does it work the same without this TLV present?

I have seen before similar requests from vendor support teams to add non-existing TLVs to config files but they were not sure about it and were just trying different things until it worked.

I saw only one mention into DPoE MULPI 2.0 about it but not a full description of the TLV.

Another option would be that MULPI 3.1 Chapter C.2.1.4.8 is wrong/incomplete and a ECN should be written to Cable Labs to correct it.

AdrianSimionov commented 8 years ago

Finally found it. It is in L2VPN specification, Chapter B.6 L2VPN specification refers for TLVs under a 43 sub-TLV.

Anyway, this should be accepted as I have seen it used in DPoE spec, just that I was not able to find the sub-chapter with the encoding of this TLV. I have seen it used in DOCSIS CM config files also.