rlaager / docsis

This program encodes a DOCSIS binary configuration file from a human-readable text configuration file.
http://docsis.sourceforge.net
GNU General Public License v2.0
114 stars 70 forks source link

memcpy of incorrect size when writing dialplan #47

Closed hoelzro closed 8 years ago

hoelzro commented 8 years ago

A fairly recent commit (c4af430) increased the size of local_char in add_dialplan, but the corresponding call to memcpy was not updated:

https://github.com/rlaager/docsis/blob/e42b4b2d279d6a2e8f4da2b64ffbbdd1a1f6695c/src/docsis.c#L213

This works OK on little-endian systems like x86, but will likely break on big-endian systems.