search

rlaager / docsis

This program encodes a DOCSIS binary configuration file from a human-readable text configuration file.
http://docsis.sourceforge.net
GNU General Public License v2.0
114 stars 70 forks source link

Program will crash if used with invalid parameter #48

Closed jcrosso closed 8 years ago

jcrosso commented 8 years ago

By chance I've found that 0.9.9 will segfault if used with a bad first parameter (for example "docsis e"). This can be avoided by adding and extra condition to the last match used by the arg's parser (in docsis.c:430):

if (argc && encode_docsis)   {

Cheers JC

AdrianSimionov commented 8 years ago

I will have to check if its the only bad parameter which generates a segmentation fault.

Thanks for reporting.