It is usually considered bad form to print to stderr unless an error actually occured, and some scripting languages will consider a command to have failed if stderr isn't empty. This tool currently prints the following text to stderr when a modem configuration is successfully encoded:
$ docsis -e - delme keyfile delme2 > /dev/null
##### Calculating CMTS MIC using TLVs:
##### End of CMTS MIC TLVs
--- MD5 DIGEST: 0xf90e368f5d979a2d5093bbaba37f1497
Final content of config file:
This PR changes these lines to instead print to stdout so that stderr is empty when the encoding succeeds.
I think part of the point of this was to keep this separate from the actual output on stdout. This whole thing is a mess, though. This change helps fix the test suite for me, so I've accepted it.
It is usually considered bad form to print to stderr unless an error actually occured, and some scripting languages will consider a command to have failed if stderr isn't empty. This tool currently prints the following text to stderr when a modem configuration is successfully encoded:
This PR changes these lines to instead print to stdout so that stderr is empty when the encoding succeeds.