search

rlaager / docsis

This program encodes a DOCSIS binary configuration file from a human-readable text configuration file.
http://docsis.sourceforge.net
GNU General Public License v2.0
115 stars 70 forks source link

version 0.9.9 /proposal/: #53

Open xarafaxz opened 7 years ago

xarafaxz commented 7 years ago 
* Feature: Allowing use MIB-MODULE-NAME:: MODULE-NAME-SPACE:: et cetera in SnmpMibObject TLV which i strongly recommend
    that resolve problems with mibs name colision, for example: PacketCable/EuroPacketCable, Motorola/Compal enterprise mibs.
    you can use "-f" switch to include MIB-MODULE-NAME:: prefixes in config dump
* Feature: Allowing use C-style inline comments "//"
* Feature: Allow use custom mib for packetcable hash signing becasuse "-eu" / EuroPacketCable and "-na" PacketCable are not enough
    use "-H [MIB]" switch to set custom hash mib.
* Attempt to cleanup option parsing mess. Now option parsing is getopt based. However due to preserving option compatibility it is create another mess. Just slighty lesser, i think.
rlaager commented 7 years ago

This should be at least four pull requests, one for each feature.

AdrianSimionov commented 7 years ago

For each feature (pull request) I would recommend to also update README.md with a short description if the usage is changing. This helps users understand how to use the tool.

xarafaxz commented 7 years ago

This should be at least four pull requests, one for each feature.

Well that's a lot of work. And only inline config comments are easly separable. Getopt based parsing influence everything else. For example to separate: custom mib hashing i need to write old style parsing, and then cleans it up in another patch.

Also the whole patch is tested with internal project tests, my internals, and use productively. If i split it into four i need to test every one as a separate.

xarafaxz commented 7 years ago

For each feature (pull request) I would recommend to also update README.md with a short description if the usage is changing. This helps users understand how to use the tool.

Currently command line parsing should be fully compatible with older version (0.9.8), so no user intervention is required.

Changing command line options should be discused separatly.

AdrianSimionov commented 7 years ago

Well that's a lot of work.

I am not going anywhere. I am looking forward to it as some are something I had in mind for a long time but never did it, for example the getopt feature.