search

rlaager / docsis

This program encodes a DOCSIS binary configuration file from a human-readable text configuration file.
http://docsis.sourceforge.net
GNU General Public License v2.0
114 stars 70 forks source link

FrameLossMeasurementTransmissionPeriodicity incorrect data type #65

Closed Sicarius128 closed 5 years ago

Sicarius128 commented 5 years ago

All instances of FrameLossMeasurementTransmissionPeriodicity are using ushort but should be uchar. TLVs have a length of "1"

B.3.24.4.2.2 Frame Loss Measurement Transmission Periodicity This subtype is used to configure the transmission periodicity of the Frame Loss measurement. SubType Length Value 43.5.24.4.2.2 1 Integer times in milliseconds. If value is = 0, then FLM test is to be run once.

292c292
< { 442,    "FrameLossMeasurementTransmissionPeriodicity", 2, 440, (encode_uchar),        (decode_uchar),         0,           0             }, /* TLV 22.43.5.24.4.2.2 L2VPN-I13 Annex B.3.24.4.2.2 */
---
> { 442,    "FrameLossMeasurementTransmissionPeriodicity", 2, 440, (encode_ushort),       (decode_ushort),         0,           0             }, /* TLV 22.43.5.24.4.2.2 L2VPN-I13 Annex B.3.24.4.2.2 */
489c489
< { 852,    "FrameLossMeasurementTransmissionPeriodicity", 2, 850, (encode_uchar),       (decode_uchar),         0,           0             }, /* TLV 23.43.5.24.4.2.2 L2VPN-I13 Annex B.3.24.4.2.2 */
---
> { 852,    "FrameLossMeasurementTransmissionPeriodicity", 2, 850, (encode_ushort),       (decode_ushort),         0,           0             }, /* TLV 23.43.5.24.4.2.2 L2VPN-I13 Annex B.3.24.4.2.2 */
659c659
< { 976,    "FrameLossMeasurementTransmissionPeriodicity", 2, 974, (encode_uchar),       (decode_uchar),         0,           0             }, /* TLV 24.43.5.24.4.2.2 L2VPN-I13 Annex B.3.24.4.2.2 */
---
> { 976,    "FrameLossMeasurementTransmissionPeriodicity", 2, 974, (encode_ushort),       (decode_ushort),         0,           0             }, /* TLV 24.43.5.24.4.2.2 L2VPN-I13 Annex B.3.24.4.2.2 */
820c820
< { 1103,   "FrameLossMeasurementTransmissionPeriodicity", 2, 1101, (encode_uchar),      (decode_uchar),         0,           0             }, /* TLV 25.43.5.24.4.2.2 L2VPN-I13 Annex B.3.24.4.2.2 */
---
> { 1103,   "FrameLossMeasurementTransmissionPeriodicity", 2, 1101, (encode_ushort),      (decode_ushort),         0,           0             }, /* TLV 25.43.5.24.4.2.2 L2VPN-I13 Annex B.3.24.4.2.2 */
963c963
< { 1234,   "FrameLossMeasurementTransmissionPeriodicity", 2, 1232, (encode_uchar),      (decode_uchar),         0,           0             }, /* TLV 26.43.5.24.4.2.2 L2VPN-I13 Annex B.3.24.4.2.2 */
---
> { 1234,   "FrameLossMeasurementTransmissionPeriodicity", 2, 1232, (encode_ushort),      (decode_ushort),         0,           0             }, /* TLV 26.43.5.24.4.2.2 L2VPN-I13 Annex B.3.24.4.2.2 */
1128c1128
< { 1384,   "FrameLossMeasurementTransmissionPeriodicity", 2, 1382, (encode_uchar),      (decode_uchar),         0,           0             }, /* TLV 43.5.24.4.2.2 L2VPN-I13 Annex B.3.24.4.2.2 */
---
> { 1384,   "FrameLossMeasurementTransmissionPeriodicity", 2, 1382, (encode_ushort),      (decode_ushort),         0,           0             }, /* TLV 43.5.24.4.2.2 L2VPN-I13 Annex B.3.24.4.2.2 */
1343c1343
< { 706,    "FrameLossMeasurementTransmissionPeriodicity", 2, 704, (encode_uchar),       (decode_uchar),         0,           0             }, /* TLV 60.43.5.24.4.2.2 L2VPN-I13 Annex B.3.24.4.2.2 */
---
> { 706,    "FrameLossMeasurementTransmissionPeriodicity", 2, 704, (encode_ushort),       (decode_ushort),         0,           0             }, /* TLV 60.43.5.24.4.2.2 L2VPN-I13 Annex B.3.24.4.2.2 */
rlaager commented 5 years ago

I'll take your word for it, as I have no way to test this. I merged this patch (which was reversed, BTW). Thanks!