search

rlabduke / MolProbity

Protein and nucleic acid validation service
Other
59 stars 30 forks source link

Adding a Python version check #2

Open ScarabMonkey opened 9 years ago

ScarabMonkey commented 9 years ago

Due to MolProbity's use of "list comprehension" (which could alternatively be replaced with 'for' loops) it therefore requires Python 2.7 or newer. This fork merely adds a python version check to the configure script which exits before going any further.

smlewis commented 9 years ago

Can you put the pull-from-cbflib directly (instead of the horrible local tarball) into this pull request too? I'll merge it all into master and then squash-cherrypick-patch it into the 4.2 branch as a bug fix.

chrissciwilliams commented 9 years ago

A note on Python in MolProbity: A correct version of Python (2.7.8) for use with MolProbity is supplied with cctbx. This Python is made available when the cctbx environment is sourced, and should be used for all cctbx and MolProbity operations.

If a machine's local Python (rather than the cctbx-supplied Python) is being used by MolProbity, that is probably a bug and we'd appreciate knowing where this occurs.

By my understanding, if everything is set up correctly, version-checking Python should not be necessary.

ScarabMonkey commented 9 years ago

I believe it is the configure script itself that requires Python 2.7.

I'll check tomorrow to see if Apache is successfully using the cctbx-supplied Python...

Merlin Hartley

On 25 Aug 2015, at 21:53, chrissciwilliams notifications@github.com wrote:

A note on Python in MolProbity: A correct version of Python (2.7.8) for use with MolProbity is supplied with cctbx. This Python is made available when the cctbx environment is sourced, and should be used for all cctbx and MolProbity operations.

If a machine's local Python (rather than the cctbx-supplied Python) is being used by MolProbity, that is probably a bug and we'd appreciate knowing where this occurs.

By my understanding, if everything is set up correctly, version-checking Python should not be necessary.

— Reply to this email directly or view it on GitHub.

ScarabMonkey commented 9 years ago

The downside to this is that I'm using wget because of SourceForge redirections not working under curl... perhaps svn would be better?

Merlin

Merlin Hartley

On 25 Aug 2015, at 21:25, Steven Lewis notifications@github.com wrote:

Can you put the pull-from-cbflib directly (instead of the horrible local tarball) into this pull request too? I'll merge it all into master and then squash-cherrypick-patch it into the 4.2 branch as a bug fix.

— Reply to this email directly or view it on GitHub.