rlabduke / probe

Evaluate and visualize protein interatomic packing
http://kinemage.biochem.duke.edu/software/probe.php
10 stars 4 forks source link

use fabs instead of abs for floating point arg in examineOneDotEach() #1

Closed wojdyr closed 9 years ago

wojdyr commented 9 years ago

i've spotted it because of Clang warning. Abs is truncating the number here, for instance abs(8.9) gives 8. In C it's unlike in C++ where abs() is overloaded.

smlewis commented 9 years ago

I've seen this and am trying to get one of my Probe colleagues to approve it, but the relevant person is out of town for a while. I think it's correct but don't want to mess around in their code. Thanks!