search

rlabrecque / Steamworks.NET

Steamworks wrapper for Unity / C#
http://steamworks.github.io
MIT License
2.83k stars 368 forks source link

Unity Engine 6.00 does not finish compiling #654

Open ninpl opened 6 days ago

ninpl commented 6 days ago

Hi, when importing package "Release 2024.8.0" into Unity Engine version "6000.0.23f1", the engine keeps compiling the files over and over again.

A temporary solution is to comment out the files:

I have verified that the functionality to create the steam_appid.txt file is executed, but it fails to create the DefineSymbols. I'll check it out in depth when I have more time.

ninpl commented 5 days ago

602 Seems to fix it

JamesMcGhee commented 1 day ago

Seeing this as well with the latest

Library\PackageCache\com.rlabrecque.steamworks.net\Editor\RedistInstall.cs(65,67): error CS0103: The name 'NamedBuildTarget' does not exist in the current context

SSormunen commented 1 day ago

I managed to quick fix "Library\PackageCache\com.rlabrecque.steamworks.net\Editor\RedistInstall.cs(65,67): error CS0103: The name 'NamedBuildTarget' does not exist in the current context" error by adding missing "using UnityEditor.Build" into the start of the RedistInstall.cs file.

leonard4 commented 21 hours ago

Unity 6 (6000.0.26f1) still has an infinite loop with the latest package installed from the git URL and with the fixes above for the RedistInstall.cs merge from, #602.

Only fix was to remove both Redist files when importing the unitypackage and copy the app id file by hand.

SSormunen commented 20 hours ago

Unity 6 (6000.0.26f1) still has an infinite loop with the latest package installed from the git URL and with the fixes above for the RedistInstall.cs merge from, #602.

Only fix was to remove both Redist files when importing the unitypackage and copy the app id file by hand.

I'm also using 6000.0.26f1 and i dont have any infinite loops or other issues with building. Except that i needed to add that "using UnityEditor.Build" line in RedistInstall.cs

JamesMcGhee commented 20 hours ago

Same for me on 6000.0.25f1 all I needed was the using statement.

And I didn't need that until I updated Steamworks.NET Not sure what changed but I imported Steamworks.NET a few weeks maybe a month ago and updated the project as you do.

Just today a user reported this issue so I updated Steamworks.NET to check and see if I could reproduce and yes ... yes I can

I looked at the change logs and didn't see anything that jumped out at me as a recent change that could cause this issue so it is a bit of a head-scratcher as to how/why this started.

The solution of adding statement though does correct the issue for me.

rlabrecque commented 18 hours ago

Can one of you two make that PR? I'll check back and get it in ASAP.

I'll also try some of this out on multiple engine versions tonight.

JamesMcGhee commented 16 hours ago

Sure will do that in just a min

JamesMcGhee commented 15 hours ago

Done however check the note in that

So whatever caused this isn't Unity, it has to be some change to Steamworks.NET that was made in the past few days ... I didn't notice anything when I looked at the history of this file but I haven't looked to deeply past that.

Same issue happens on Unity 2022 with the current latest so the issue introduced has to be from a change made to Steamworks.NET in the past couple days. Its not a change that I noticed when I looked at the file history but its not specific to Unity v6000.x