rladies / rladies.github.io

R-Ladies Hugo Website
Other
11 stars 20 forks source link

fix #250 #253

Closed drmowinckels closed 7 months ago

github-actions[bot] commented 12 months ago

:tada: The preview is built! Check it out

github-actions[bot] commented 11 months ago

:tada: The preview is built! Check it out

cosimameyer commented 11 months ago

Not sure why but this doesn't look good to me:

Screenshot 2023-10-25 at 19 27 51

Might be a caching thing but I cleaned it and it still shows up, so we should verify that this isn't the problem.

We also have two issues with the links:

All other links to other places look good :)

cosimameyer commented 11 months ago

Another idea as to why there are two R-Ladies Gabarone chapters showing up: could it be the way the preview is built? (that it basically shows the "old" and the "new" entry?)

cosimameyer commented 11 months ago

Making my way through the open tickets - I now also saw Simi's issue (linking it here for reference: https://github.com/rladies/rladies.github.io/issues/250)

drmowinckels commented 11 months ago

Another idea as to why there are two R-Ladies Gabarone chapters showing up: could it be the way the preview is built? (that it basically shows the "old" and the "new" entry?)

no, they start with a clean slate building the whole thing from scratch every time. so that should not be it. I'll look again.

drmowinckels commented 11 months ago

@maelle , can I request another set of eyes on this. What are we missing?

maelle commented 9 months ago

The chapter appears twice in chapters_meetup.json

https://github.com/rladies/rladies.github.io/blob/0d0f1f82c8cb4ed754116ccb856c2deca94ab43c/data/chapters_meetup.json#L644

https://github.com/rladies/rladies.github.io/blob/0d0f1f82c8cb4ed754116ccb856c2deca94ab43c/data/chapters_meetup.json#L614

drmowinckels commented 9 months ago

The chapter appears twice in chapters_meetup.json

https://github.com/rladies/rladies.github.io/blob/0d0f1f82c8cb4ed754116ccb856c2deca94ab43c/data/chapters_meetup.json#L644

https://github.com/rladies/rladies.github.io/blob/0d0f1f82c8cb4ed754116ccb856c2deca94ab43c/data/chapters_meetup.json#L614

Thank you! That was driving me nuts, and I had made myself blind looking in a specific spot.

drmowinckels commented 9 months ago

this is a temp fix really, this file is script generated, so I'm looking into why its duplicated there to begin with.

github-actions[bot] commented 9 months ago

:tada: The preview is built! Check it out

github-actions[bot] commented 7 months ago

:tada: The preview is built! Check it out :eyes: