rlalfo / google-http-java-client

Automatically exported from code.google.com/p/google-http-java-client
0 stars 0 forks source link

HttpHeader.parse fails on AppEngine for combined Set-Cookie headers #187

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Version of google-http-java-client: 1.12.0-beta
Java environment: AppEngine 1.7.4

Problem:
For certain web-sites, parsing a returned Set-Cookie HTTP header via 
java.net.HttpCookie#parse fails with java.lang.IllegalArgumentException 
("Illegal cookie attribute")

Fix:
AppEngine recently introduced the long-awaited fix for the combined HTTP 
headers issue (http://code.google.com/p/googleappengine/issues/detail?id=3379)

To take advantage of the fix, replace "fetchResponse.getHeaders()" with 
"fetchResponse.getHeadersUncombined()" in UrlFetchResponse.java.

Original issue reported on code.google.com by dles...@gmail.com on 5 Jan 2013 at 12:25

GoogleCodeExporter commented 9 years ago
Great news, thanks!

Original comment by yan...@google.com on 24 Jan 2013 at 2:10

GoogleCodeExporter commented 9 years ago

Original comment by yan...@google.com on 5 Feb 2013 at 4:48

GoogleCodeExporter commented 9 years ago
Confirmed that getHeadersUncombined works:
https://codereview.appspot.com/8778043/

Original comment by yan...@google.com on 15 Apr 2013 at 9:52

GoogleCodeExporter commented 9 years ago

Original comment by yan...@google.com on 18 Apr 2013 at 2:33