search

rlancaste / stellarsolver

GNU General Public License v3.0
89 stars 47 forks source link

Resource leak in astrometry/blind/blind.c #30

Closed TallFurryMan closed 3 years ago

TallFurryMan commented 3 years ago

https://github.com/rlancaste/stellarsolver/blob/e0aa8d394aa9ddd5ad9c1052fff249d019913c49/stellarsolver/astrometry/blind/blind.c#L1392-L1398

hdr and fout are lost here.

TallFurryMan commented 3 years ago

https://scan3.coverity.com/reports.htm#v48457/p13483/fileInstanceId=42786234&defectInstanceId=10334090&mergedDefectId=303715 https://scan3.coverity.com/reports.htm#v48457/p13483/fileInstanceId=42786234&defectInstanceId=10333862&mergedDefectId=303750

rlancaste commented 3 years ago

I think this one is fixed

TallFurryMan commented 3 years ago

Yes, although the next function in the file (write_scamp_file) has three more leaks of the same type.