rlancaste / stellarsolver

GNU General Public License v3.0
89 stars 47 forks source link

Resource leak in astrometry/blind/verify.c #31

Closed TallFurryMan closed 3 years ago

TallFurryMan commented 3 years ago

https://github.com/rlancaste/stellarsolver/blob/e0aa8d394aa9ddd5ad9c1052fff249d019913c49/stellarsolver/astrometry/blind/verify.c#L86-L89

vf is lost here.

TallFurryMan commented 3 years ago

https://scan3.coverity.com/reports.htm#v48457/p13483/fileInstanceId=42786287&defectInstanceId=10333955&mergedDefectId=303747

rlancaste commented 3 years ago

I think this one is fixed

TallFurryMan commented 3 years ago

Agreed. Line 804 leaks starid as well, same construct. I didn't enter it at first because I thought we were not using the bounding circle feature, I'm not sure anymore if we do, I tend to think we don't.