search

rlancaste / stellarsolver

GNU General Public License v3.0
92 stars 47 forks source link

Resource leak in astrometry/util/fitsioutils.c #39

Closed TallFurryMan closed 3 years ago

TallFurryMan commented 4 years ago

https://github.com/rlancaste/stellarsolver/blob/e0aa8d394aa9ddd5ad9c1052fff249d019913c49/stellarsolver/astrometry/util/fitsioutils.c#L1137-L1140

fits is lost here.

TallFurryMan commented 4 years ago

https://scan3.coverity.com/reports.htm#v48457/p13483/fileInstanceId=42786386&defectInstanceId=10334103&mergedDefectId=303733 https://scan3.coverity.com/reports.htm#v48457/p13483/fileInstanceId=42786386&defectInstanceId=10333982&mergedDefectId=303740 https://scan3.coverity.com/reports.htm#v48457/p13483/fileInstanceId=42786386&defectInstanceId=10334047&mergedDefectId=303742

rlancaste commented 3 years ago

I think this one is fixed

TallFurryMan commented 3 years ago

303740 is fixed, but 303740and 303742 are still current. We need to reopen this one.