search

rlancaste / stellarsolver

GNU General Public License v3.0
89 stars 47 forks source link

Resource leak in sep/extract.cpp #51

Closed TallFurryMan closed 3 years ago

TallFurryMan commented 3 years ago

https://github.com/rlancaste/stellarsolver/blob/e0aa8d394aa9ddd5ad9c1052fff249d019913c49/stellarsolver/sep/extract.cpp#L355-L359

https://github.com/rlancaste/stellarsolver/blob/e0aa8d394aa9ddd5ad9c1052fff249d019913c49/stellarsolver/sep/extract.cpp#L752

If conv is true, cdscan leaks here.

knro commented 3 years ago

I believe this is fixed.

TallFurryMan commented 3 years ago

Coverity complains it is not, but probably this is because of the sequence of markers. Postponing, although the issue is real.

TallFurryMan commented 3 years ago

As a side note, there are a bunch of uninitialised variables being used in that file, you may want to check the report.