search

rlancaste / stellarsolver

GNU General Public License v3.0
89 stars 47 forks source link

Resource leak in astrometry/util/starkd.c #59

Closed TallFurryMan closed 3 years ago

TallFurryMan commented 3 years ago

https://github.com/rlancaste/stellarsolver/blob/e0aa8d394aa9ddd5ad9c1052fff249d019913c49/stellarsolver/astrometry/util/starkd.c#L559-L562

io is lost here.

TallFurryMan commented 3 years ago

https://scan3.coverity.com/reports.htm#v48457/p13483/fileInstanceId=42786305&defectInstanceId=10333899&mergedDefectId=303558 https://scan3.coverity.com/reports.htm#v48457/p13483/fileInstanceId=42786305&defectInstanceId=10334129&mergedDefectId=303655

TallFurryMan commented 3 years ago

Also io is passed null explicitly to kdtree_fits_write_tree, which de-references it unconditionally, in some cases.

rlancaste commented 3 years ago

I think this one is fixed