search

rlancaste / stellarsolver

GNU General Public License v3.0
89 stars 47 forks source link

Resource leak in astrometry/util/fitstable.c #61

Closed TallFurryMan closed 3 years ago

TallFurryMan commented 3 years ago

https://github.com/rlancaste/stellarsolver/blob/e0aa8d394aa9ddd5ad9c1052fff249d019913c49/stellarsolver/astrometry/util/fitstable.c#L298-L301

buf is lost here.

https://github.com/rlancaste/stellarsolver/blob/e0aa8d394aa9ddd5ad9c1052fff249d019913c49/stellarsolver/astrometry/util/fitstable.c#L644-L647

dest and tempdata are lost here.

https://github.com/rlancaste/stellarsolver/blob/e0aa8d394aa9ddd5ad9c1052fff249d019913c49/stellarsolver/astrometry/util/fitstable.c#L945-L948

fitsdata and cdata are lost here.

https://github.com/rlancaste/stellarsolver/blob/e0aa8d394aa9ddd5ad9c1052fff249d019913c49/stellarsolver/astrometry/util/fitstable.c#L975-L979

fitsdata and tempdata are lost here.

https://github.com/rlancaste/stellarsolver/blob/e0aa8d394aa9ddd5ad9c1052fff249d019913c49/stellarsolver/astrometry/util/fitstable.c#L839-L843

buf and src are lost here.

https://github.com/rlancaste/stellarsolver/blob/e0aa8d394aa9ddd5ad9c1052fff249d019913c49/stellarsolver/astrometry/util/fitstable.c#L1274-L1281

outtable is lost here.

TallFurryMan commented 3 years ago

https://scan3.coverity.com/reports.htm#v48457/p13483/fileInstanceId=42786390&defectInstanceId=10334131&mergedDefectId=303547 https://scan3.coverity.com/reports.htm#v48457/p13483/fileInstanceId=42786390&defectInstanceId=10334042&mergedDefectId=303554 https://scan3.coverity.com/reports.htm#v48457/p13483/fileInstanceId=42786390&defectInstanceId=10334087&mergedDefectId=303565 https://scan3.coverity.com/reports.htm#v48457/p13483/fileInstanceId=42786390&defectInstanceId=10333959&mergedDefectId=303625 https://scan3.coverity.com/reports.htm#v48457/p13483/fileInstanceId=42786390&defectInstanceId=10334132&mergedDefectId=303679 https://scan3.coverity.com/reports.htm#v48457/p13483/fileInstanceId=42786390&defectInstanceId=10333894&mergedDefectId=303711

rlancaste commented 3 years ago

I think this one is fixed