rlancaster96 / Demultiplex

0 stars 0 forks source link

Ruben assignment critique #3

Open surbhinahata opened 1 year ago

surbhinahata commented 1 year ago

Hey Ruben! Great work! I don't have any comments to add, everything in the pseudocode and answers was really easy to follow. Your code was well written and formatted. I really loved the idea of using dictionary to hold indices. It seems like the "real" code you will generate would be fast/memory efficient and easy to loop over. I don't see any possibilities of fire (figurative) with your actual code :)