rland93 / pendsim

A simple inverse pendulum simulation + visualization.
MIT License
0 stars 5 forks source link

Can `requirements.txt` dependencies be streamlined/relaxed? #11

Closed cooperrc closed 2 years ago

cooperrc commented 2 years ago

@rland93, I'm reviewing PendSim software with JOSE and ran into installation issue _might be an issue on my end or NumPy version that's pinned,

following the docs installation

git clone https://github.com/rland93/pendulum.git
cd pendulum
pip install -r requirements.txt

Most of the requirements seem to install, but then NumPy 1.21.1 throws a big error.

        note: This error originates from a subprocess, and is likely not a problem with pip.
        ERROR: Failed building wheel for numpy
      Failed to build numpy
      ERROR: Could not build wheels for numpy, which is required to install pyproject.toml-based projects
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× pip subprocess to install build dependencies did not run successfully.
│ exit code: 1
╰─> See above for output.

A question: Are all of the packages listed in requirements.txt required? or is this an autogenerated requirements package?

Maybe some of the pinned versions could be removed from requirements.txt?

rland93 commented 2 years ago

Yes, requirements.txt was just the output of pip freeze.

Resolved!

One more thing to note: I renamed master to main, which might cause issues if you pull from your local. If that's the case you can delete and clone again.

Thanks for the review!