search

rland93 / pendsim

A simple inverse pendulum simulation + visualization.
MIT License
0 stars 5 forks source link

Edit paper - result of `write-good` suggestions #14

Closed cooperrc closed 2 years ago

cooperrc commented 2 years ago

I added suggested edits to avoid passive voice and make the paper a little clearer (its really great, just some minor preferences on my part)

One thing that really stood out L181:

The user can implement any control policy by creating a new class
[??link to docs??](https://github.com/openjournals/jose-reviews/issues/168). Users
can test new open-ended controller designs.  Controllers can dump data
into the simulation results so that intermediate control inputs are
accessible to the final results of the simulation.

It would be great to document how the user can implement and contribute to this ongoing project. If one person builds a neural network trainer out of this, how can they contribute to the original repo? or should they?

cooperrc commented 2 years ago

Awesome!

Glad you appreciate the work. Some people like to add passive voice, but I prefer active especially for technical + scientific docs