search

rlaphoenix / nton

Nintendo Switch NRO to NSP Forwarder
GNU General Public License v3.0
161 stars 5 forks source link

Pressing + or any action to exit a Homebrew, fails and reopens instead #1

Open rlaphoenix opened 1 year ago

rlaphoenix commented 1 year ago

Describe the bug Any action that is meant to exit the Homebrew (and go back to e.g., the Homebrew Menu or Home Menu) is failing and instead just closes and reopens the Homebrew.

To Reproduce Steps to reproduce the behavior:

  1. Make an NSP for Homebrew Menu or use the premade one.
  2. Install it with Goldleaf.
  3. Open it and press + once the menu has fully loaded.

You will see it go black and reopen, kind of like a refresh in this case.

Expected behavior It was meant to close the homebrew and the forwarder entirely.

Screenshots N/A.

Additional context Some users have reported crashes when done instead of it closing and reopening.

rlaphoenix commented 1 year ago

This issue is likely needing to be handled by the exefs ROM, of which we do not have source code for at the moment. So currently this issue is out of scope of this project.

rlaphoenix commented 1 year ago

The Forwarder ROM is now Open-Source: https://github.com/Skywalker25/Forwarder-Mod

Skywalker25 commented 1 year ago

I did some research and I found that someone else had made a patch to allow a nro forwarder to exit via B/+button or by closing the nro via inside the forwarder. I copied the patch into the forwarder mod and it seems to have work, I've only tried awoo-installer nro, and a snes retroarch forwarder. awoo installer was able to exit to home menu via B button and closing in-app. and the retroarch forwarder was able to exit to home menu via closing the game from retroarch menu. the exefs contains the latest hbl 2.4.3 forwarder mod and the exit patch exefs.zip

rlaphoenix commented 1 year ago

I did some research and I found that someone else had made a patch to allow a nro forwarder to exit via B/+button or by closing the nro via inside the forwarder. I copied the patch into the forwarder mod and it seems to have work, I've only tried awoo-installer nro, and a snes retroarch forwarder. awoo installer was able to exit to home menu via B button and closing in-app. and the retroarch forwarder was able to exit to home menu via closing the game from retroarch menu. the exefs contains the latest hbl 2.4.3 forwarder mod and the exit patch exefs.zip

Could you add the modifications to your source repository of the Forwarder-Mod?

rlaphoenix commented 1 year ago

It seems to work, but DBI is very weird with it. It seems to be laggy when first opening it and selecting the Exit option from the menu or pressing the B button causes it to freeze for a good 15-30s and then it closes (no errors). Strange. Do you get this behaviour as well?

Edit: If you wait that 15-30s before exiting, it exits immediately. This is likely just DBI having a fit. If you can put the patches on your GitHub repo then I will push this and make a new version release.

rlaphoenix commented 1 year ago

I've committed the exefs rom you provided to master, but source code for the changes would be great.

HookedBehemoth commented 1 year ago

I assume he meant this patch: https://github.com/switchbrew/nx-hbloader/compare/master...HookedBehemoth:nx-hbloader:master

I forgot how this was supposed to work but there also was a custom hbmenu https://github.com/switchbrew/nx-hbmenu/compare/master...HookedBehemoth:nx-hbmenu:sane_exit