search

rlauer6 / perl-amazon-s3

A portable client library for working with and managing Amazon S3 buckets and keys.
http://search.cpan.org/dist/Amazon-S3/
2 stars 7 forks source link

github.com:jojessf/perl-Amazon-S3 Init #9

Closed jojessf closed 1 year ago

jojessf commented 1 year ago

add $Bucket->copy_key( $inkey, $newkey ) <3

rlauer6 commented 1 year ago

Hi! Thanks for the PR!....I'll incorporate this into the next version, however I will be making a few changes to satisfy perlcritic ... also README.md is autogenerated from the pod. Thanks again!

rlauer6 commented 1 year ago

Spent some time today looking at the CopyObject request API. I think we can beef up copy_key a bit so that it allows for more flexible exercising of that API.

New branch copy_object pushed this morning...check out the documentation in Amazon::S3::Bucket for copy_object and see what you think. I've also added a very basic unit test for copy_object() in t/01-api.t.

rlauer6 commented 1 year ago

As I have not gotten any feedback, I am incorporating the new copy_object() method into the new 0.59 version and closing this PR.

jojessf commented 1 year ago

Have been unfortunately busy. I like your implementation of copy_object, and it does what it needs to do. Copies an object, optionally between buckets.

Did spend a bit of time considering it, but I do not have anything tangible to offer at this time. Would like convenience methods for "x-amz-copy-source-if-modified-since" & "x-amz-copy-source-if-match" - but I haven't had the time to figure out how to get those to actually work just yet. Also want convenience methods to add tags, inhibit tag inheritance, inhibit the inheritance of specific tags - but haven't tested any of that.

Might come back with another PR when I have more time to put into this - if that's okay with you, of course.

Thank you, rlauer6! =>