search

rlayhacker / torchat

Automatically exported from code.google.com/p/torchat
0 stars 0 forks source link

torchat is not using globally set browser #91

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
When clicking on a link in torchat it doesn't start the globally set browser 
(in my case it started konqueror instead of my globally set iceweasel).

Original issue reported on code.google.com by kdg83...@trash-mail.com on 17 Jan 2011 at 5:23

GoogleCodeExporter commented 8 years ago 
yes. Its starting /etc/alternatives/x-www-browser, which *should* be (or link 
to) the "default" browser (at least this method was hyped as *the* solution a 
few years ago, maybe it has changed again). Unfortunately the notion of the 
"default browser" seems not very clear in linux, every desktop envionment (and 
every application) has its own settings for this. I'm trying to find a better 
way, its already on my todo list.

Most likely I will end up having the user configure the browser manually in the 
torchat configuration.

Original comment by prof7...@gmail.com on 17 Jan 2011 at 9:50

GoogleCodeExporter commented 8 years ago 
I believe there is a way to use the "default browser", since all the other 
applications I've installed are using iceweasel as default browser.
So I tried to find out which setting my system is using. My results so far are 
that /usr/bin/sensible-browser (seems to be a Debian specific script), 
/etc/alternatives/gnome-www-browser and /etc/alternatives/x-www-browser is not 
used by the other applications.

I'll try to find out more.

Original comment by kdg83...@trash-mail.com on 18 Jan 2011 at 3:56

GoogleCodeExporter commented 8 years ago 
this is what I mean:

/etc/alternatives/x-www-browser
/etc/alternatives/gnome-www-browser
/usr/bin/sensible-browser

/etc/alternatives/kde-www-browser
/etc/alternatives/whatever-www-browser
/etc/alternatives/yet-another-default-but-not-really-default-only-used-by-me-bro
wser

What on earth do they smoke?

Original comment by prof7...@gmail.com on 18 Jan 2011 at 12:15

GoogleCodeExporter commented 8 years ago 
You forgot /etc/alternatives/www-browser for every non x browser ;-) But to be 
fair /usr/bin/sensible-browser is just a script to choose between the different 
alternatives, not setting a new one. 

I found the python module webbrowser 
(http://docs.python.org/library/webbrowser.html). The small script (at the end 
of this posting) used from command line works fine and is starting the default 
browser iceweasel.

But after patching it into tc_gui.py torchat is using konqueror for opening 
URLs, no matter which browser is set in any of the above alternatives. I might 
have made mistakes (I suck in python) so maybe you can work it out with that 
module.

"import webbrowser

webbrowser.open_new('http://torchat.googlecode.com')"

Original comment by kdg83...@trash-mail.com on 18 Jan 2011 at 4:21

GoogleCodeExporter commented 8 years ago 
I think there is also something in wxPython itself for starting the "default" 
browser, I have to investigate whether this might be a suitable alternative. 
And also my one and only windows98 user has a problem with my windows default 
browser method on windows via cmd.exe /c start

Original comment by prof7...@gmail.com on 18 Jan 2011 at 5:02

GoogleCodeExporter commented 8 years ago 
A good source to check standard procedures in Linux is freedesktop.org. In this 
case xdg-open (part of xdg-utils)[1] is the way to go.

For wxPython it's better to use the function wxLaunchDefaultBrowser[2], since 
it should work in Windows and Unix. I attached a patch changing it to this 
function, though only tested in Linux.

[1] http://portland.freedesktop.org/wiki/
[2] http://docs.wxwidgets.org/stable/wx_miscellany.html#wxlaunchdefaultbrowser

Original comment by erik.est...@googlemail.com on 3 Feb 2011 at 6:16

Attachments:

GoogleCodeExporter commented 8 years ago 
patch from comment 6 applied in r521

I will leave this bug open for a while to see whether there are still 
complaints.

Original comment by prof7...@gmail.com on 6 Feb 2011 at 3:18

GoogleCodeExporter commented 8 years ago 
Good idea. Don't hesitate to contact me if any problems arise because of this 
patch.

Original comment by erik.est...@googlemail.com on 13 Feb 2011 at 7:08

GoogleCodeExporter commented 8 years ago 
Any complaints yet? If not, it should be safe to close this bug.

Original comment by erik.est...@googlemail.com on 25 Jun 2011 at 12:34

GoogleCodeExporter commented 8 years ago 
no complaints yet. I'm closing it now.

Original comment by prof7...@gmail.com on 26 Jun 2011 at 9:11