rlbarter / superheat

An r package for generating beautiful and customizable heatmaps
https://rlbarter.github.io/superheat/
235 stars 29 forks source link

Performance issue: force.grid.hline = T #11

Open davemcg opened 7 years ago

davemcg commented 7 years ago

On my mega long (nearly 500 row) heatmap, forcing the hline with force.grid.hline = T increases the time to make a plot by a huge amount. I'm going from a plot made in 5 seconds to a plot made in minutes, with just changing that parameter.

rlbarter commented 7 years ago

Thanks for pointing this out. I will look into it, but I suspect that it has to do with the underlying ggplot function and there may be nothing that I can do. Will let you know when I get a chance to check it out.

davemcg commented 7 years ago

Cool, just wanted to let you know.

You already know this, but this is an amazing package. Once you add color labels this will be the best heatmap-er.

rlbarter commented 7 years ago

Thanks David, I really appreciate it!