search

rlemaigre / vue3-promise-dialog

Dialogs meet promises in Vue 3 !
MIT License
69 stars 14 forks source link

Export `closeDialog` #5

Closed hognevevle closed 2 years ago

hognevevle commented 2 years ago

Allows to close a dialog from within the setup function of the dialog component

Closes #4

TODO: Fix typing of comp and update docs (we no longer should pass this when calling $close)

rlemaigre commented 2 years ago

Looks good thank you :-)

I would either remove $close entirely (in that case we'll release a v2 because it's a breaking change) or keep it exactly as it was (same signature and still need to pass this even if it isn't useful anymore) for backward compatibility and mark it deprecated. Either way I'll update the docs to remove all references to $close and document the new function closeDialog.