rlex / puppet-dnsmasq

Advanced Dnsmasq management module for puppet CFM
http://forge.puppetlabs.com/lex/dnsmasq
13 stars 47 forks source link

tag is reserved metaparameter and it prevents using negation in dhcp-boot #47

Open XANi opened 9 years ago

XANi commented 9 years ago

https://docs.puppetlabs.com/references/latest/metaparameter.html#tag

this prevents doing "anything but that tag, for example"

dnsmasq::dhcpboot { 'boot-ipxe':
    tag     => '!ipxe',
    file    => 'ipxe.pxe',
}
dnsmasq::dhcpboot {'boot-ipxe-conf':
    tag     => 'ipxe',
    file    => 'http://192.168.1.1/ipxe/menu.ipxe',
    #bootserver => '192.168.1.1' #optional
}

generates

Warning: tag is a metaparam; this value will inherit to all contained resources in the dnsmasq::dhcp definition
Error: Invalid tag '!ipxe' at /file/name

I believe it was broken in https://github.com/rlex/puppet-dnsmasq/commit/5bf863203ae3011be2f8b82de1ee43ddcc248489

rlex commented 8 years ago

this affects puppet 4.x?

XANi commented 8 years ago

Dunno, run a snippet above and check it, I dont have p4 install at hand to test it