rlf / uSkyBlock

The best skyblock bukkit plugin around...
http://dev.bukkit.org/bukkit-plugins/uskyblock/
GNU General Public License v3.0
76 stars 113 forks source link

challenges can be spammed #1258

Open Qekker opened 4 years ago

Qekker commented 4 years ago

People can spam challenges. So they complete the same challenge 100 times in a row

Muspah commented 4 years ago

Can you give me a little bit more context? Are they spamming the chat with complete messages, or what is happening exactly? What is the output of /usb version and do you have a server logfile?

Qekker commented 4 years ago

They can skip the cooldown on the challenges.

fjeddy commented 4 years ago

It took me a while to understand how the configuration works. At first I thought like you, that you could only do an achievement once within the cooldown period, but when you add the + deliminator to a challenge rewards, then the challenge can be completed an endless amount of time.

requiredItems:
        - APPLE:2;+1

When this is the requirements, then you need 2 apples to complete it the first time, the second time you need three apples, the third time you need 4 apples. Every time you complete the achievement, you need one extra Apple to complete it one more time. But, when the cooldown period is over, you reset the apples required back to 2 then + 1 for every round.

Hence, the cooldown doesn't decide how often a challenge can be completed, it defines and decides when the requirements needed to complete should be reset.

Note I agree that this bit can be a bit confusing, and at first, I thought it worked like you, that the cooldown defined how often a challenge could be completed, not when the requirements reset.