search

rlhelinski / musicbrainz-catalog

Python code for cataloging your music collection cross-referenced with MusicBrainz
GNU General Public License v2.0
2 stars 0 forks source link

Python 3 compatibility #14

Closed JonnyJD closed 10 years ago

JonnyJD commented 10 years ago

You shouldn't start a project that doesn't work on Python 3 these days. (5 years after Python 3 was released). See also: https://wiki.python.org/moin/Python2orPython3

If you don't want to release your module as a library, you can even drop support for Python 2 if you want to.

musicbrainzngs and discid are working fine with Python 3.

rlhelinski commented 10 years ago

You're right. Let's set some milestones and bridge this gap.

rlhelinski commented 10 years ago

I couldn't do it in one commit, so I created a branch. https://github.com/rlhelinski/musicbrainz-catalog/tree/python3-compat

JonnyJD commented 10 years ago

Doing something in a branch is not a bad thing. I tend to create a branch for every feature or issue for my projects, even if it could be fixed with a single commit. You can then either attach the branch to an issue (with hub, which makes a pull request out of an issue) or open a new pull request (open PR for your own project also isn't bad). Updating the branch updates the pull request.

JonnyJD commented 10 years ago

This will be fixed with #16.