This commit closes the ldap connection after authenticate.

rlidwka / sinopia-ldap

LDAP auth plugin for sinopia

18 stars 12 forks source link

This commit closes the ldap connection after authenticate. #6

Closed simonhoss closed 9 years ago

simonhoss commented 9 years ago

Otherwise nodejs throws an error: This socket has been ended by the other party

rlidwka commented 9 years ago

Original code maintained a permanent connection to ldap server. You're suggesting to make one connection per every request.

I'm not familiar with ldap, but this is not a good solution imho. Can we catch that error and re-connect to ldap server when it happens? Maybe ldap library already does it somehow?

rlidwka commented 9 years ago

Fixed in https://github.com/rlidwka/sinopia-ldap/pull/9, sorry it took so long.