search

rlidwka / sinopia

Private npm repository server
5.51k stars 656 forks source link

move away from express #92

Open rlidwka opened 10 years ago

rlidwka commented 10 years ago

... since all decisions regarding its development are now made by people who had nothing to do with express.js in the first place (see https://github.com/strongloop/express/issues/2264).

Locking down express version for now, so future updates won't be installed automatically. Only visionmedia/express is affected, so all middlewares should receive updates as they were.

PS: @dougwilson , @jonathanong , @defunctzombie - can you came up with a fork, pretty-pretty please?

dougwilson commented 10 years ago

Locking down express version for now

This is a good conservative action for now. Many projects have had this same concern. I suggested similar for now to sails.

can you came up with a fork, pretty-pretty please?

There will be something in due time. There are no critical issues pending anywhere in express, so there isn't the need for a rush right now. Using existing express versions is perfectly fine :) We will continue our path of breaking apart express into modules within expressjs and when we're ready to put them back together again (would have been express 5), we'll see where express is and what our decisions will be regarding a new project or something else.

I hope that helps :)

jonathanong commented 10 years ago

Great thing is we could consider completely breaking changes :)

defunctzombie commented 10 years ago

\o/ On Jul 31, 2014 11:44 AM, "Jonathan Ong" notifications@github.com wrote:

Great thing is we could consider completely breaking changes :)

— Reply to this email directly or view it on GitHub https://github.com/rlidwka/sinopia/issues/92#issuecomment-50801268.

z0mt3c commented 10 years ago

how about moving to hapi? i could imaging e.g. in terms of authentication sinopia could benefit from hapis plugin functionality.

rlidwka commented 10 years ago

@z0mt3c , sorry, but in their current state... no.

Even if I manage to forget about that weird idea of CLI and manifest in particular, hapi is a major overkill for this.

rlidwka commented 10 years ago

In terms of authentication, we'll have auth plugins very soon, so anyone who wants to use another authentication system, could write their own plugin.

If you want to make auth compatible with hapi or something, I could share plugin specs or open an issue to discuss that.

z0mt3c commented 10 years ago

Never mind, auth plugins sound great and i understand your position - even i like hapi and it's concepts and would not consider it to be a major overkill :-) I'm sure you will share as soon as you feel it's time.

soyuka commented 10 years ago

And what about express4 ? That might give the advantage of running sinopia as a submodule of an application (:.

rlidwka commented 10 years ago

@soyuka ,

Yes, moving to express 4 would be an improvement over what we have now.

But express development is effectively frozen, because current owners don't have enough internal knowledge and/or don't want to put too much time into it. Thus we will have to move to whatever-is-coming-next soon anyway.

So instead of investing too much time to change to express 4, and then move to whatever-is-coming-next, I'm thinking to move to whatever-is-coming-next directly and help testing it in the process.