Closed HoLo85 closed 3 years ago
Thanks for your proposed changes! Nice improvement! One thing I noticed is that the node wasn't working after packaging. The
package.json
includes afiles
array, where you need to add the newly added directory. I'd suggest to add the whole directory with all files in it withsma-device-presets/*
(See another comment about the name of that directory). You can test it by creating a package withnpm pack
.
Sorry forgot that, the folder and files are now included in the package.
@rlindner did you have a look at the last changes and can we merge the PR?
There's still a reference to devList
which prevents to node from loading:
ReferenceError: devList is not defined (line:8)
Once that's resolved, I'm fine with merging it. 👍
This PR moves the presets into separate files in the new
sma-device-presets/
folder. The presets are read when the node starts and are provided as before, accessing the presets does not change.The presets have to be placed in a file named like the options in the device selection, e.g.
sb_tripower.json
and provide the following data: