rlishtaba / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

feature req: command line options #393

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I'd like the ripping process to be more automatable for the command line
version.  

either by allowing options to be passed as command line parameters.

or a command line parameter to just accept all defaults.  

this would allow me to set rrip_cli as the default action when I insert a
CD.  The CD would rip and eject.  

This would speed up the process of ripping an entire collection at once. 
Then I could go search my music directory for any logfile with errors and
deal with them at that time.  

Original issue reported on code.google.com by galtthed...@gmail.com on 13 Jan 2010 at 5:47

GoogleCodeExporter commented 8 years ago
so it occurred to me that I could edit the source code to achieve my goal.  I 
have
never seen ruby before, but in this particular case it might be easy enough.  

I was surprised to find that there ARE command line options.  I didn't 
originally use
your tarball to install so I had no idea.  

anyway, for version. 0.5.7, the "-a" or "--all" DOES skip the track selection 
but I
almost wonder what's the point?  

so I successfully edited rubyripper_cli.rb to include a "-d" or "--usedefaults"
option.  I figured it would be efficient to add it in one place so I didn't 
have to
seek out every function that asked a question.  

I tried to make an elsif statement that came before the "open" and "number" so 
that
we could just skip those but the program bombed so I put line underneath each 
of those.  

I've never used git, so I'm now reading about it.  I'd like to share the 
changes I've
made, so if you like them they can be put in rubyripper.  

Original comment by galtthed...@gmail.com on 13 Jan 2010 at 9:31

Attachments:

GoogleCodeExporter commented 8 years ago
Well, I'm actually surprised that so many people seem to like the cli 
interface. It 
was more or less created as a proof-of-concept that multiple frontends can be 
implemented easily.

When there are bug reports I'm happy to fix the problems though. This seems to 
be a 
small request and the necessity well justified.

The most easy (and lazy) path for me is that you clone the repository, so I can 
just 
pull your changes. And after looking at them merge them with the mainline. But 
any 
patch is appreciated :). I'll run a diff at your file and see what I get.

Original comment by boukewou...@gmail.com on 6 Feb 2010 at 11:09

GoogleCodeExporter commented 8 years ago
Since I made a few other changes meanwhile on the same source, I've implemented 
the 
idea, not your code. Please let me know if it works. With a random disc of mine 
it 
seems to do just fine.

Commit: 
http://github.com/rubyripperdev/rubyripper/commit/a5848a38cdd528944a679ed8aed612
d26197
1531

Original comment by boukewou...@gmail.com on 6 Feb 2010 at 11:38