naming_various setting don't work correctly

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Set "naming_various" setting as the following: %va/%va - %t
2.
3.

What is the expected output? What do you see instead?
As the example in RubyRipper, the file shoud be created in the following
path: mybasedir/Kid Rock/Kid Rock - Cowboys.ext. The resoult instead is:
mybasedir/%va/Kid Rock - Cowboys.ext. The %va variable is not expanded.

1) What version of rubyripper are you using? On what operating system?
->v0.5.7, the curretnt last version

2) Are you using the gtk2 or the commandline interface?
->gtk2

3) Is the problem gone with the default settings? If so, please attach your
settings file ($HOME/.rubyripper/settings).
->The default settings are not applicable for this problem

4) Does the problem only happen on a specific disc? If so, please attach
the output of cdparanoia -Q. Also the freedb output would be nice if it may
be related to it.
->No. For all Varius Artist Albun that I had tried to rip.

Please provide any additional information below.
The %va variable in the filename scheme shall be expanded also in the
directory path. Actually, the %va variable work only to define the file name. 

Original issue reported on code.google.com by davideca...@gmail.com on 7 Feb 2010 at 2:39

[GoogleCodeExporter]

Notice that %va and %a were mixed up for the 'other' codec. This is recently 
fixed in 
latest git. %a is always the artist for a given track, %va is the album artist 
(Most 
often "various artists") if the disc is marked as various artists.

The behaviour of %va for the directory is actually on purpose. The main idea is 
that 
the files of each album are always saved in a single directory. That's where 
the log 
file, the cue file and the playlist file are saved as well. I fixed another 
issue in 
the names as well in commit: 
http://github.com/rubyripperdev/rubyripper/commit/c678c6d69d3d40c39d58ebcf0c8ab1
283ca
46826

So let's give some examples of the results:

In latest git %va/%va - %t would result in
$basedir/Various Artists/Various Artists - Trackname1.ext
$basedir/Various Artists/Various Artists - Trackname2.ext

With %va/%a - %t the result would be
$basedir/Various Artists/Artist 1 - Trackname1.ext
$basedir/Various Artists/Artist 2 - Trackname2.ext

The result of %a/%a - %t would be identical. The %a in the directory name is 
forced 
to be the album artist.

Original comment by boukewou...@gmail.com on 7 Feb 2010 at 9:37

• Changed state: WontFix

[GoogleCodeExporter]

I tried to do the following experiments:

-  %va/%a - %t the result has been:
$basedir/%va/Various Artists - Trackname1.ext  (%va variable has not been 
expanded).
- %va/%va - %t the result has been:
$basedir/%va/Artist Track - Trackname1.ext (%va variable has not been expanded).
- %a/%va - %t the result has been:
$basedir/Various Artist/Artist Track - Trackname1.ext
- %a/%a - %t the result has been:
$basedir/Various Artist/Various Artist - Trackname1.ext

I would like that the resoult of the %va/%va - %t is: 
$basedir/Artist Track/Artist Track - Trackname1.ext

and that the log file and playlist is created in the $basedir/.

Analizing the code, I see the problem during the set of DirName. In the code, 
the %va
variable is not considered in the definition of the directory name. I tried to 
add "
, "%va => "Temp" in the def of the dirname and the variable is expanded 
correctly
during the creation of the folder.

Furthermore, the directory is created before the program start the rip. The 
method
for the directory creation should be called for each track extracted to perfor 
the
directory creation with the desired name.

Thanks for your attention.

Davide

Original comment by giuliaro...@gmail.com on 8 Feb 2010 at 9:39

[GoogleCodeExporter]

So you have different results. I am wondering if you did use latest git then.

But anyhow, multiple output dirs for the same codec won't be supported. It will 
break 
rubyripper in all kind of ugly ways. I see the next issues flying in already: 
the 
playlist does not work, how come? Where is the log file? Why does rubyripper 
crash 
here? Why does it delete the dir where tracks from a previous disc are already 
in?

And besides : I don't find it logical to do this. If you need this kind of 
feature, 
just use some program like Easytag for these discs.

Original comment by boukewou...@gmail.com on 8 Feb 2010 at 10:00