search

rlishtaba / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

GUI crashes if maxThreads = 0 #419

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
1) Please describe the steps to reproduce the situation:

a. Set maxThreads to 0
b. Click on 'Rip cd now!'

2) What is the expected output? What do you see instead?

/usr/local/lib/ruby/1.9.1/thread.rb:247:in `initialize': queue size must 
be positive (ArgumentError)
    from /tmp/rubyripper/rr_lib.rb:2077:in `new'
    from /tmp/rubyripper/rr_lib.rb:2077:in `initialize'
    from /tmp/rubyripper/rr_lib.rb:2440:in `new'
    from /tmp/rubyripper/rr_lib.rb:2440:in `startRip'
    from /usr/local/bin/rrip_gui:306:in `block in do_rip'

3) What version of rubyripper are you using?

Revision cfb8df (17/05/2010) on Xubuntu 10.04 with Ruby 1.9.1p376 and 
ruby-gtk2-0.19.4

4) Is this not already fixed with the latest & greatest code?

No.

5) Does the problem happen with different discs? If not, please attach
the output of cdparanoia -Q.

Yes.

6) Please explain why this change is important for you. Also, how many
users would benefit from this change?

I can work around it by setting maxThreads > 0 (particularly since I rip 
to wave so it has no effect I assume) but I would guess this will affect 
all users who don't set extra encoding threads.

Original issue reported on code.google.com by tin...@gmail.com on 22 May 2010 at 1:18

GoogleCodeExporter commented 8 years ago 
Thanks for reporting this one, I am glad to report it is fixed with commit:
http://github.com/rubyripperdev/rubyripper/commit/8c2031b1196bf5e67344f55bc10f89
918e01
3dc8

Original comment by boukewou...@gmail.com on 22 May 2010 at 7:52