rlishtaba / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

stacktrace when .rubyripper/ not empty after migration #426

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
note: I am using the current (fetched today) git version

The settings are migrated from .rubyripper/ to .config/rubyripper/

So far only the .rubyripper/settings (and freedb.yaml somewhere else) seems
to get transfered, but no user-created files in this directory.
If user-created files are present rubyripper fails to delete .rubyripper/

/usr/lib/ruby/site_ruby/1.9.1/rr_lib.rb:157:in `delete': Directory not
empty - /home/jonnyjd/.rubyripper (Errno::ENOTEMPTY)
    from /usr/lib/ruby/site_ruby/1.9.1/rr_lib.rb:157:in `migrationCheck'
    from /usr/lib/ruby/site_ruby/1.9.1/rr_lib.rb:127:in `initialize'
    from /usr/bin/rrip_cli:41:in `new'
    from /usr/bin/rrip_cli:41:in `initialize'
    from /usr/bin/rrip_cli:486:in `new'
    from /usr/bin/rrip_cli:486:in `<main>'

I have these files (I created myself) left:
freedb.yaml.save  settings.cdrdao  settings.cdrw  settings.default

I would probose either:
a) move all of these files to .config/rubyripper/
even if in example freedb.yaml.save wouldn't belong there.
b) don't delete .rubyripper/ or only delete if it is empty

Either way: A message about the migration should be displayed !

What steps will reproduce the problem?
1. make soure you have something like .rubyripper/testfile in your home
2. start rrip_cli (or similar)

Original issue reported on code.google.com by goo...@JonnyJD.net on 30 May 2010 at 12:05

GoogleCodeExporter commented 8 years ago
Interesting enough:

After moving these files manually the folder .rubyripper is deleted. However it 
is
recreated afterwards. (and stays empty)

Original comment by goo...@JonnyJD.net on 30 May 2010 at 12:56

GoogleCodeExporter commented 8 years ago
This should all be fixed with commit:
http://github.com/rubyripperdev/rubyripper/commit/3df7173fdd1eb3e9b68a9a5a947369
ae6d4
b3797

A message is shown in a terminal that the auto file migration is started. If 
the old 
dir can not be removed this will be shown as a message.

I fixed the troublemaker for creating the old dir as well. It was in the freedb 
yaml 
related code.

Some testing would be appreciated.

Original comment by boukewou...@gmail.com on 30 May 2010 at 2:35

GoogleCodeExporter commented 8 years ago
Well, it seems to work for me now.

The message is shown. My non-empty folder doesn't "crash" the program anymore 
and
when I delete .rubyripper it does not get created anymore. And if the directory 
is
empty, it gets deleted.

Original comment by goo...@JonnyJD.net on 30 May 2010 at 6:04

GoogleCodeExporter commented 8 years ago
Well, I see that you put a lot of effort in testing it. I'm sorry you couldn't 
crash 
it anymore... Maybe next time :D

Original comment by boukewou...@gmail.com on 30 May 2010 at 6:28